Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docker task-manager-db postgress healthcheck #5753

Merged
merged 3 commits into from
Feb 14, 2025
Merged

Fix docker task-manager-db postgress healthcheck #5753

merged 3 commits into from
Feb 14, 2025

Conversation

jefvantongerloo
Copy link
Contributor

Fixes #5739

@jefvantongerloo
fix-task-manager-db-healthcheck
a0f3d21 
Signed-off-by: Jef Vantongerloo <jefvantongerloo@gmail.com>
@jefvantongerloo jefvantongerloo mentioned this pull request Feb 13, 2025
Closed
@jefvantongerloo
fix yamllint line-length error
b1b2598 
Signed-off-by: Jef Vantongerloo <jefvantongerloo@gmail.com>
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Feb 14, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #5753 will not alter performance

Comparing jefvantongerloo:jefvt-fix-5739-docker-postgress-healthcheck (3945331) with stable (cd51fff)

Summary

✅ 11 untouched benchmarks

@wvandeun
Copy link
Contributor

Thanks, seems we still have a spelling check issue, not exactly sure why this wasn't catched before.
Please just add Postgess and healthcheck to .vale/styles/spelling-exceptions.txt.

@jefvantongerloo
Add healthcheck & Postgress (opsmill#5753)
3945331 
Signed-off-by: Jef Vantongerloo <jefvantongerloo@gmail.com>
@jefvantongerloo
Copy link
Contributor Author

Thanks, seems we still have a spelling check issue, not exactly sure why this wasn't catched before. Please just add Postgess and healthcheck to .vale/styles/spelling-exceptions.txt.

Done

@wvandeun wvandeun self-requested a review February 14, 2025 08:49
wvandeun
wvandeun approved these changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@wvandeun wvandeun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @jefvantongerloo, great work!

@wvandeun wvandeun merged commit 3a98a35 into opsmill:stable Feb 14, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wvandeun wvandeun wvandeun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: docker-compose task-manager-db Postgress healthcheck fails
2 participants
@jefvantongerloo @wvandeun