Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docker task-manager-db postgress healthcheck #5741

Closed
wants to merge 3 commits into from
Closed

Fix docker task-manager-db postgress healthcheck #5741

wants to merge 3 commits into from

Conversation

jefvantongerloo
Copy link
Contributor

Fixes #5739

@jefvantongerloo
fix-task-manager-db-healthcheck
4cf8fa2 
Signed-off-by: Jef Vantongerloo <jefvantongerloo@gmail.com>
@jefvantongerloo jefvantongerloo requested a review from a team as a code owner February 13, 2025 13:32
@cla-assistant CLA Assistant
Copy link

cla-assistant bot commented Feb 13, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@wvandeun
Copy link
Contributor

wvandeun commented Feb 13, 2025 •
edited
Loading

First of all, thank you for your contribution!

Can you please target the stable branch for this PR?
We should do the same change in these locations:

@jefvantongerloo
fix-task-manager-db-healthcheck
db195a5 
Signed-off-by: Jef Vantongerloo <jefvantongerloo@gmail.com>
@jefvantongerloo
Merge branch 'jefvt-fix-5739-docker-postgress-healthcheck' of https:/…
838b235 
…/github.com/jefvantongerloo/infrahub into jefvt-fix-5739-docker-postgress-healthcheck
@jefvantongerloo
Copy link
Contributor Author

I added the changes. Can I rebase on stable branch or do I have to fork on stable and create a new PR?

@jefvantongerloo jefvantongerloo changed the base branch from develop to stable February 13, 2025 15:01
@jefvantongerloo jefvantongerloo changed the base branch from stable to develop February 13, 2025 15:01
@wvandeun
Copy link
Contributor

Yes, please rebase on stable and change the target branch to stable as well.

@jefvantongerloo jefvantongerloo closed this by deleting the head repository Feb 13, 2025
@jefvantongerloo
Copy link
Contributor Author

New PR on stable #5753

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jefvantongerloo @wvandeun