Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix performance issue for count only queries #4459

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

ogenstad
Copy link
Contributor

This PR fixes a problem in the get_list mixin where we always ran the full query even if the user only requested a count of the nodes.

Fixes #4454

Note: Due to changes that have already been made to the develop branch this will probably cause a merge conflict when we merge stable back the next time.

@ogenstad ogenstad added the type/bug Something isn't working as expected label Sep 25, 2024
@github-actions github-actions bot added the group/backend Issue related to the backend (API Server, Git Agent) label Sep 25, 2024
@ogenstad ogenstad marked this pull request as ready for review September 25, 2024 20:35
@ogenstad ogenstad requested a review from a team September 25, 2024 20:36
Copy link
Collaborator

@dgarros dgarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good
if you think there is a good chance it will produce a merge conflict, I think we should cherry pick the commit into develop right away

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
group/backend Issue related to the backend (API Server, Git Agent) type/bug Something isn't working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants