Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge stable back into develop with resolved merge conflicts #4471

Closed
wants to merge 7 commits into from

Conversation

ogenstad
Copy link
Contributor

@ogenstad ogenstad commented Sep 27, 2024

Replaces #4463

As #4459 introduced a merge conflict between stable and develop the initial thought was to cherry-pick that commit and merge it back into stable. However resolving a merge conflict when cherry-picking doesn't quite seem to work as the operation rewrites the commit id.

When trying locally and merging stable into my branch i ended up with the same merge conflict again:

❯ git merge stable
Auto-merging backend/infrahub/core/schema_manager.py
Auto-merging backend/infrahub/graphql/types/mixin.py
CONFLICT (content): Merge conflict in backend/infrahub/graphql/types/mixin.py
Automatic merge failed; fix conflicts and then commit the result.
diff --cc backend/infrahub/graphql/types/mixin.py
index 1543fd455,6138a46b8..000000000
--- a/backend/infrahub/graphql/types/mixin.py
+++ b/backend/infrahub/graphql/types/mixin.py
@@@ -50,10 -51,6 +50,13 @@@ class GetListMixin
              edges = fields.get("edges", {})
              node_fields = edges.get("node", {})

++<<<<<<< HEAD
 +            permissions = fields.get("permissions")
 +            if permissions:
 +                response["permissions"] = await get_permissions(db=db, schema=cls._meta.schema, context=context)
 +
++=======
++>>>>>>> stable
              objs = []
              if edges or "hfid" in filters:
                  objs = await NodeManager.query(
@@@ -63,12 -60,12 +66,21 @@@
                      fields=node_fields,
                      at=context.at,
                      branch=context.branch,
++<<<<<<< HEAD
 +                    limit=query_args.limit,
 +                    offset=query_args.offset,
 +                    account=context.account_session,
 +                    include_source=True,
 +                    include_owner=True,
 +                    partial_match=query_args.partial_match,
++=======
+                     limit=limit,
+                     offset=offset,
+                     account=context.account_session,
+                     include_source=True,
+                     include_owner=True,
+                     partial_match=partial_match,
++>>>>>>> stable
                  )

As a result of that I've instead taken all of the changes from stable and resolved the merge conflict like we normally do with an intermediate branch that includes the original commit.

@ogenstad ogenstad added the ci/skip-changelog Don't include this PR in the changelog label Sep 27, 2024
@github-actions github-actions bot added the group/backend Issue related to the backend (API Server, Git Agent) label Sep 27, 2024
@ogenstad ogenstad marked this pull request as ready for review September 27, 2024 09:01
@ogenstad ogenstad requested a review from dgarros September 27, 2024 09:01
@ajtmccarty
Copy link
Contributor

can be closed. is superseded by #4480

@dgarros dgarros closed this Sep 28, 2024
@ogenstad ogenstad deleted the pog-try-again branch September 28, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/skip-changelog Don't include this PR in the changelog group/backend Issue related to the backend (API Server, Git Agent)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants