Merge stable back into develop with resolved merge conflicts #4471
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #4463
As #4459 introduced a merge conflict between stable and develop the initial thought was to cherry-pick that commit and merge it back into stable. However resolving a merge conflict when cherry-picking doesn't quite seem to work as the operation rewrites the commit id.
When trying locally and merging stable into my branch i ended up with the same merge conflict again:
As a result of that I've instead taken all of the changes from
stable
and resolved the merge conflict like we normally do with an intermediate branch that includes the original commit.