feat(core-utils): remove old query params handled by new mode selector #712
Conversation
|
I think this PR should be a breaking change PR. @miles-grant-ibigroup? |
BREAKING CHANGE: removes old query parameters that are not needed
daniel-heppner-ibigroup
force-pushed
the
remove-old-qp
branch
from
f89460e to
e697697
Compare
|
Lost track of this PR for a bit, but I force pushed the breaking change commit. If you had this branch cloned, you'll need to delete it and pull it again. Or maybe force pull. |
daniel-heppner-ibigroup
assigned binh-dam-ibigroup and unassigned daniel-heppner-ibigroup
There was a problem hiding this comment.
The comment on lines 1-2 doesn't apply anymore and can be removed.
There was a problem hiding this comment.
I think the file should still be removed entirely, but probably not because of settingsselector anymore.
There was a problem hiding this comment.
We can probably remove the profile-only params that have routingTypes: ["PROFILE"] (these are holdouts from before my time) such as startTime, endTime.
There was a problem hiding this comment.
In the same vein, I think we can get rid of routingTypes, profileRewrite alltogether. Thoughts?
There was a problem hiding this comment.
Yes! I was worried someone was using those, like TriMet, but I think you're right that we can remove them.
|
I deleted a lot more of the query parameters, but that caused some problems in the SettingsSelectorPanel, which is still being used in some instances and we aren't ready to fully deprecate, even with a breaking change. So I had to revert those changes, I think at this point we can merge this to fix the original bug. Please assign this to Miles after you've reviewed and then Miles can merge it, since I'm out the next week. |
daniel-heppner-ibigroup
assigned binh-dam-ibigroup and unassigned daniel-heppner-ibigroup
| "maxBikeDistance": 4828, | ||
| "maxBikeTime": 20, | ||
| "maxEScooterDistance": 4828, | ||
| "maxWalkDistance": 1609, | ||
| "maxWalkTime": 15, |
There was a problem hiding this comment.
Also remove these deleted parameters from defaultParams in query.js.
|
I'm closing the PR, let's try again without all the jank from the revert commits. |
This PR removes a bunch of old query parameters that are no longer needed here, either because they're now directly managed by the mode selector (mode settings) or because they're no longer supported by OTP (like max walk distance).