Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-utils): remove query params conflicting with new mode selector #727

Conversation

daniel-heppner-ibigroup
Copy link
Contributor

BREAKING CHANGE: removes wheelchair and walkReluctance query parameters

Really keeping it simple with this one... Only removing the two parameters that are handled by the new mode selector settings dropdowns.

Please check the general settings panel story. Does this matter? The settings selector panel and trip options stuff is unchanged.

BREAKING CHANGE: removes wheelchair and walkReluctance query parameters
@binh-dam-ibigroup
Copy link
Collaborator

@daniel-heppner-ibigroup What was the reason for not removing the max walk/bike distance and some of the other no-longer supported items from #712?

@daniel-heppner-ibigroup
Copy link
Contributor Author

daniel-heppner-ibigroup commented Mar 20, 2024

@daniel-heppner-ibigroup What was the reason for not removing the max walk/bike distance and some of the other no-longer supported items from #712?

I wanted to, but there is still some usage of components that depend on these parameters in an OTP1 environment. Take a look at the Trip Options stories to see how they appear.

Really, removing old/OTP1 parameters is actually a separate thing from removing the conflicting ones with the mode selector. The ones being removed here are actually modern parameters that are just being managed elsewhere, vs removing the ones you mentioned would be removing old parameters from this file which we are phasing out anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants