Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade OBA, remove camsys-apps.com from Maven repos #6041

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Upgrade OBA, remove camsys-apps.com from Maven repos #6041

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b10ead
Upgrade OBA, remove camsys-apps.com from Maven repos
leonardehrenfried Sep 4, 2024
2fdace7
Update version
leonardehrenfried Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 1 addition & 12 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -533,11 +533,6 @@
<name>Open Source Geospatial Foundation Repository</name>
<url>https://repo.osgeo.org/repository/release/</url>
</repository>
<repository>
<id>onebusaway-releases</id>
<name>Onebusaway Releases Repo</name>
<url>https://repo.camsys-apps.com/releases/</url>
</repository>
</repositories>

<dependencyManagement>
Expand Down Expand Up @@ -824,13 +819,7 @@
<dependency>
<groupId>org.onebusaway</groupId>
<artifactId>onebusaway-gtfs</artifactId>
<version>1.4.17</version>
<exclusions>
<exclusion>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-simple</artifactId>
</exclusion>
</exclusions>
Comment on lines -828 to -833
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this exclusion removed?

Copy link
Member Author

@leonardehrenfried leonardehrenfried Sep 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we should never have needed it in the first place. This artifact included an slf4j implementation in its dependencies which competed with our own (logback). I removed it upstream by setting its scope to test.

<version>3.2.3</version>
</dependency>
<!-- Processing is used for the debug GUI (though we could probably use just Java2D) -->
<dependency>
Expand Down
Loading