Upgrade OBA, remove camsys-apps.com from Maven repos #6041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6041 +/- ##
==========================================
Coverage 69.74% 69.74%
- Complexity 17319 17320 +1
==========================================
Files 1960 1960
Lines 74268 74273 +5
Branches 7603 7605 +2
==========================================
+ Hits 51795 51801 +6
+ Misses 19831 19830 -1
Partials 2642 2642 ☔ View full report in Codecov by Sentry. |
vpaturet
approved these changes
Sep 9, 2024
optionsome
reviewed
Sep 9, 2024
Comment on lines
-828
to
-833
| <exclusions> | ||
| <exclusion> | ||
| <groupId>org.slf4j</groupId> | ||
| <artifactId>slf4j-simple</artifactId> | ||
| </exclusion> | ||
| </exclusions> |
There was a problem hiding this comment.
Why was this exclusion removed?
There was a problem hiding this comment.
Because we should never have needed it in the first place. This artifact included an slf4j implementation in its dependencies which competed with our own (logback). I removed it upstream by setting its scope to test.
optionsome
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
One of the first actions as a maintainer was to deploy all OBA artifacts on Maven Central so the Maven Repo camsys-apps.com is no longer needed.
The main changes in the library code itself are
cc @VillePihlava