Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parking updater for NOI Open Data Hub #5769

Merged

Conversation

leonardehrenfried
Copy link
Member

Summary

Adds a sandbox vehicle parking updater for the Italian region of South Tyrol.

It also tightens up the vehicle parking data model so that you must supply an id and a coordinate, which required some changes in the test code.

Unit tests

Added.

Documentation

Added.

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 86.44068% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 67.79%. Comparing base (f4438a8) to head (95c4f6c).
Report is 29 commits behind head on dev-2.x.

Files Patch % Lines
...tripplanner/ext/vehicleparking/noi/NoiUpdater.java 85.00% 5 Missing and 1 partial ⚠️
...r/ext/vehicleparking/noi/NoiUpdaterParameters.java 50.00% 1 Missing ⚠️
...hicle_parking/VehicleParkingDataSourceFactory.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             dev-2.x    #5769   +/-   ##
==========================================
  Coverage      67.79%   67.79%           
- Complexity     16530    16533    +3     
==========================================
  Files           1905     1907    +2     
  Lines          72293    72347   +54     
  Branches        7441     7444    +3     
==========================================
+ Hits           49010    49051   +41     
- Misses         20764    20773    +9     
- Partials        2519     2523    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leonardehrenfried
Copy link
Member Author

cc @dulvui @rcavaliere

@leonardehrenfried leonardehrenfried merged commit 39fe08e into opentripplanner:dev-2.x Apr 10, 2024
5 checks passed
@leonardehrenfried leonardehrenfried deleted the noi-parking branch April 10, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants