Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove NOI parking updater #6098

Merged

Conversation

leonardehrenfried
Copy link
Member

Summary

Removes the NOI-specific vehicle parking updater as it has been replaced by the SIRI one.

Documentation

Updated and auto-generated.

@leonardehrenfried leonardehrenfried requested a review from a team as a code owner September 27, 2024 07:16
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.83%. Comparing base (cd5277e) to head (49d66a1).
Report is 79 commits behind head on dev-2.x.

Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #6098      +/-   ##
=============================================
- Coverage      69.84%   69.83%   -0.02%     
+ Complexity     17454    17443      -11     
=============================================
  Files           1975     1973       -2     
  Lines          74600    74548      -52     
  Branches        7634     7631       -3     
=============================================
- Hits           52107    52062      -45     
+ Misses         19843    19835       -8     
- Partials        2650     2651       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@habrahamsson-skanetrafiken
Copy link
Contributor

Should this skip the changelog? Since this removes a feature, maybe it should be included? But I'm not sure where we usually draw the line.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed the non-sandbox code. The documentation and configuration changes look good.

@leonardehrenfried
Copy link
Member Author

The original addition also didn't have a changelog entry: #5769

@leonardehrenfried leonardehrenfried merged commit e78a9ca into opentripplanner:dev-2.x Oct 4, 2024
5 checks passed
@leonardehrenfried leonardehrenfried deleted the remove-noi branch October 13, 2024 21:26
@t2gran t2gran added this to the 2.7 (next release) milestone Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants