-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove NOI parking updater #6098
Remove NOI parking updater #6098
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6098 +/- ##
=============================================
- Coverage 69.84% 69.83% -0.02%
+ Complexity 17454 17443 -11
=============================================
Files 1975 1973 -2
Lines 74600 74548 -52
Branches 7634 7631 -3
=============================================
- Hits 52107 52062 -45
+ Misses 19843 19835 -8
- Partials 2650 2651 +1 ☔ View full report in Codecov by Sentry. |
Should this skip the changelog? Since this removes a feature, maybe it should be included? But I'm not sure where we usually draw the line. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reviewed the non-sandbox code. The documentation and configuration changes look good.
The original addition also didn't have a changelog entry: #5769 |
Summary
Removes the NOI-specific vehicle parking updater as it has been replaced by the SIRI one.
Documentation
Updated and auto-generated.