-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CORE-670 Switch from Osano to CookieYes #72
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
d9256fc
Switch from Osano to CookieYes
Dantemss c0a99bd
Version bump
Dantemss 564909d
Always check if CookieYes already loaded in useEffect hook, fix ladle…
Dantemss f9bdf4d
Added missing hook dependency
Dantemss 4056181
Merge branch 'main' into cookieyes
Dantemss File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,34 +1,57 @@ | ||
// Jest Snapshot v1, https://goo.gl/fbAQLP | ||
|
||
exports[`ManageCookies with osano renders button 1`] = ` | ||
exports[`ManageCookies when CookieYes loads renders button 1`] = ` | ||
<button | ||
className="sc-gsnTZi sc-dkzDqf czjxlp jmylct" | ||
onClick={[Function]} | ||
className="sc-gsnTZi sc-dkzDqf czjxlp jmylct cky-banner-element" | ||
> | ||
Manage Cookies | ||
</button> | ||
`; | ||
|
||
exports[`ManageCookies with osano renders button in wrapper 1`] = ` | ||
exports[`ManageCookies when CookieYes loads renders button in wrapper 1`] = ` | ||
<div> | ||
<button | ||
className="sc-gsnTZi sc-dkzDqf czjxlp jmylct" | ||
onClick={[Function]} | ||
className="sc-gsnTZi sc-dkzDqf czjxlp jmylct cky-banner-element" | ||
> | ||
Manage Cookies | ||
</button> | ||
</div> | ||
`; | ||
|
||
exports[`ManageCookies with osano renders button with content 1`] = ` | ||
exports[`ManageCookies when CookieYes loads renders button with content and correct class 1`] = ` | ||
<button | ||
className="sc-gsnTZi sc-dkzDqf czjxlp jmylct" | ||
onClick={[Function]} | ||
className="sc-gsnTZi sc-dkzDqf czjxlp jmylct cky-banner-element" | ||
> | ||
some content | ||
</button> | ||
`; | ||
|
||
exports[`ManageCookies without osano renders nothing 1`] = `null`; | ||
exports[`ManageCookies with CookieYes already loaded renders button 1`] = ` | ||
<button | ||
className="sc-gsnTZi sc-dkzDqf czjxlp jmylct cky-banner-element" | ||
> | ||
Manage Cookies | ||
</button> | ||
`; | ||
|
||
exports[`ManageCookies with CookieYes already loaded renders button in wrapper 1`] = ` | ||
<div> | ||
<button | ||
className="sc-gsnTZi sc-dkzDqf czjxlp jmylct cky-banner-element" | ||
> | ||
Manage Cookies | ||
</button> | ||
</div> | ||
`; | ||
|
||
exports[`ManageCookies with CookieYes already loaded renders button with content and correct class 1`] = ` | ||
<button | ||
className="sc-gsnTZi sc-dkzDqf czjxlp jmylct cky-banner-element" | ||
> | ||
some content | ||
</button> | ||
`; | ||
|
||
exports[`ManageCookies without cookieYes renders nothing 1`] = `null`; | ||
|
||
exports[`ManageCookies without osano renders nothing, even a wrapper 1`] = `null`; | ||
exports[`ManageCookies without cookieYes renders nothing, even a wrapper 1`] = `null`; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really understand why I had to do 2 separate
act
s here. I thought everything should work withrenderer.create()
not inact
. But unless I wraprenderer.create()
in its ownact
, the component never renders.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need that
act
to make sure that hooks and state changes finish before the test runs. otherwise cookieyes never loads and the component renders null.