CORE-670 Switch from Osano to CookieYes #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dantemss
commented
Feb 17, 2025
| <ManageCookiesLink /> | ||
| ); | ||
| }); | ||
| act(() => { document.dispatchEvent(bannerLoadEvent); }); |
There was a problem hiding this comment.
I don't really understand why I had to do 2 separate acts here. I thought everything should work with renderer.create() not in act. But unless I wrap renderer.create() in its own act, the component never renders.
There was a problem hiding this comment.
I think you need that act to make sure that hooks and state changes finish before the test runs. otherwise cookieyes never loads and the component renders null.
Dantemss
requested review from
a team and
bethshook
and removed request for
a team
bethshook
reviewed
Feb 19, 2025
bethshook
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Component used by Rex