Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apply aria-label to NavBarButton #70

Merged
merged 2 commits into from
Feb 18, 2025
Merged

apply aria-label to NavBarButton #70

merged 2 commits into from
Feb 18, 2025

Conversation

bethshook
Copy link
Contributor

@bethshook bethshook requested a review from jivey February 14, 2025 05:25
jivey
jivey approved these changes Feb 18, 2025
View reviewed changes
Copy link
Member

@jivey jivey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Looks like ignoreRestSiblings made this easy for me to miss.

@bethshook bethshook merged commit 30babb1 into main Feb 18, 2025
3 checks passed
@bethshook bethshook deleted the core-762 branch February 18, 2025 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jivey jivey jivey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bethshook @jivey