apply aria-label to NavBarButton (#70)

add missing prop Co-authored-by: Beth Shook <es66@rice.edu>
openstax · Feb 18, 2025 · 30babb1 · 30babb1
1 parent d8c3784
commit 30babb1
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/src/components/NavBarButton.tsx b/src/components/NavBarButton.tsx
@@ -16,7 +16,7 @@ export const NavBarButton = styled(
     "aria-label": ariaLabel,
     ...props
   }: NavBarButtonProps) => (
-    <Button className={className} {...props}>
+    <Button className={className} aria-label={ariaLabel} {...props}>
       {icon &&
         (typeof icon === "string" ? (
           <img aria-hidden="true" src={icon} alt="" />

diff --git a/src/components/__snapshots__/NavBarButton.spec.tsx.snap b/src/components/__snapshots__/NavBarButton.spec.tsx.snap
@@ -2,6 +2,7 @@
 
 exports[`NavBarButton matches base64 icon snapshot 1`] = `
 <button
+  aria-label="dots menu"
   className="sc-bczRLJ dKgZvy"
   data-rac=""
   id="react-aria-5"
@@ -68,6 +69,7 @@ exports[`NavBarButton matches icon and text snapshot 1`] = `
 
 exports[`NavBarButton matches svg icon snapshot 1`] = `
 <button
+  aria-label="info"
   className="sc-bczRLJ dKgZvy"
   data-rac=""
   id="react-aria-3"

diff --git a/src/components/__snapshots__/NavBarMenuButtons.spec.tsx.snap b/src/components/__snapshots__/NavBarMenuButtons.spec.tsx.snap
@@ -31,6 +31,7 @@ exports[`NavBarMenuButton matches snapshot 1`] = `
 exports[`NavBarPopoverButton matches custom aria label snapshot 1`] = `
 <button
   aria-expanded={false}
+  aria-label="Custom label"
   className="sc-bczRLJ dKgZvy"
   data-rac=""
   id="react-aria-5"