Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retargeting question-info CSS #85

Merged
merged 4 commits into from
Jan 30, 2025
Merged

Retargeting question-info CSS #85

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9884df9
Retargeting question-info CSS
RoyEJohnson Jan 15, 2025
499f68f
Add note about exercises.json
RoyEJohnson Jan 15, 2025
33d0ea0
Bring the font size and margins back down
RoyEJohnson Jan 29, 2025
e3ba607
Update version
RoyEJohnson Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,6 @@ UI components for OpenStax assessments.
- `yarn test` run tests and get coverage results
- `yarn lint` run eslint
- `yarn ladle serve` run Ladle server at http://localhost:61000 to view component stories

Note: exercises.json needs to be created at the top level for ladle
See src/components/Print.stories.tsx
5 changes: 3 additions & 2 deletions src/components/Card.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,11 @@ const StepCardHeader = styled.div`
line-height: 3rem;
letter-spacing: -0.72px;
div.question-info {
h2.question-info {
display: flex;
align-items: baseline;
font-weight: bold;
font-size: inherit;
margin: inherit;
.question-id {
font-weight: normal;
Expand Down
10 changes: 5 additions & 5 deletions src/components/__snapshots__/Card.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ exports[`StepCard matches snapshot 1`] = `
className="sc-bczRLJ eAXREJ"
>
<div
className="sc-dkzDqf hbFgnH"
className="sc-dkzDqf ihThJf"
>
<div>
<h2
Expand Down Expand Up @@ -55,7 +55,7 @@ exports[`StepCard matches snapshot with more than one question 1`] = `
className="sc-bczRLJ eAXREJ"
>
<div
className="sc-dkzDqf hbFgnH"
className="sc-dkzDqf ihThJf"
>
<div>
<h2
Expand Down Expand Up @@ -109,7 +109,7 @@ exports[`TaskStepCard can optionally provide task 1`] = `
className="sc-bczRLJ eAXREJ exercise-step"
>
<div
className="sc-dkzDqf hbFgnH"
className="sc-dkzDqf ihThJf"
>
<div>
<h2
Expand Down Expand Up @@ -148,7 +148,7 @@ exports[`TaskStepCard can optionally provide type 1`] = `
className="sc-bczRLJ eAXREJ exercise-step"
>
<div
className="sc-dkzDqf hbFgnH"
className="sc-dkzDqf ihThJf"
>
<div>
<h2
Expand Down Expand Up @@ -187,7 +187,7 @@ exports[`TaskStepCard matches snapshot 1`] = `
className="sc-bczRLJ eAXREJ exercise-step"
>
<div
className="sc-dkzDqf hbFgnH"
className="sc-dkzDqf ihThJf"
>
<div>
<h2
Expand Down
10 changes: 5 additions & 5 deletions src/components/__snapshots__/Exercise.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ exports[`Exercise using step data matches snapshot 1`] = `
className="sc-bczRLJ eAXREJ exercise-step sc-evZas dPJYxI sc-ksZaOG kmSAkY"
>
<div
className="sc-dkzDqf hbFgnH"
className="sc-dkzDqf ihThJf"
>
<div>
<h2
Expand Down Expand Up @@ -203,7 +203,7 @@ exports[`Exercise with question state data matches snapshot 1`] = `
className="sc-bczRLJ eAXREJ exercise-step sc-evZas dPJYxI sc-ksZaOG kmSAkY"
>
<div
className="sc-dkzDqf hbFgnH"
className="sc-dkzDqf ihThJf"
>
<div>
<h2
Expand Down Expand Up @@ -442,7 +442,7 @@ exports[`Exercise with question state data renders header icons with multiple ch
className="sc-bczRLJ eAXREJ exercise-step sc-evZas dPJYxI sc-ksZaOG kmSAkY"
>
<div
className="sc-dkzDqf hbFgnH"
className="sc-dkzDqf ihThJf"
>
<div>
<h2
Expand Down Expand Up @@ -767,7 +767,7 @@ exports[`Exercise with question state data renders header icons with two-step ex
className="sc-bczRLJ eAXREJ exercise-step sc-evZas dPJYxI sc-ksZaOG kmSAkY"
>
<div
className="sc-dkzDqf hbFgnH"
className="sc-dkzDqf ihThJf"
>
<div>
<h2
Expand Down Expand Up @@ -1078,7 +1078,7 @@ exports[`Exercise with question state data shows a detailed solution 1`] = `
className="sc-bczRLJ eAXREJ exercise-step sc-evZas dPJYxI sc-ksZaOG kmSAkY"
>
<div
className="sc-dkzDqf hbFgnH"
className="sc-dkzDqf ihThJf"
>
<div>
<h2
Expand Down