Retargeting question-info CSS #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jomcarvajal
approved these changes
Jan 15, 2025
RoyEJohnson
force-pushed
the
fix-styling-for-question-info-heading
branch
from
bd7e6d6 to
cd9c8ad
Compare
jomcarvajal
approved these changes
Jan 15, 2025
|
@jivey It looks like fixing the CSS target took care of the issue. Just wanted you to take a look to see if there might be anything else I missed. |
|
Pulling down the branch, it looks like the h2 is using the default heading size: Before the commit it looks like it was 1.8rem: |
jivey
requested changes
Jan 22, 2025
RoyEJohnson
force-pushed
the
fix-styling-for-question-info-heading
branch
from
5184b90 to
499f68f
Compare
|
Tom's comment about styling suggests that H2s should look like H2s, but maybe that's not what he's saying. |
RoyEJohnson
force-pushed
the
fix-styling-for-question-info-heading
branch
from
d7964a1 to
33d0ea0
Compare
|
I added a commit to have font size and margin inherit, rather than using the h2 font and margins. |
jivey
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removed Print.stories, since it had an invalid import
CORE-418