Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow all manifest PRs to run manifest-check workflow #5234

Merged
merged 1 commit into from
Jan 14, 2025
+2 −2
Merged

Allow all manifest PRs to run manifest-check workflow #5234

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/manifests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,15 @@ name: manifests-ci-check

on:
pull_request:
types: [labeled, synchronize]
types: [opened, synchronize]
paths:
- 'manifests/**/*.yml'
- '!manifests/templates/**/'
- 'legacy-manifests/**/*.yml'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can remove this line? Since it's in legacy-manifest folder, we shouldn't modify any of the existing manifests. We will be only move manifests to the legacy folder right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right but incase we move files from manifest to legacy, the checks will also test for validations. Example, all tags exists and manifests are valid.


jobs:
list-changed-manifests:
if: ${{ github.repository == 'opensearch-project/opensearch-build' && github.event.label.name == 'manifest-ci-check' }}
if: ${{ github.repository == 'opensearch-project/opensearch-build' }}
runs-on: ubuntu-latest
outputs:
matrix: ${{ steps.set-matrix.outputs.matrix }}
Expand Down
Loading