Allow all manifest PRs to run manifest-check workflow #5234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
gaiksaya
requested review from
dblock,
peterzhuamazon,
rishabh6788,
zelinh,
prudhvigodithi,
Divyaasm and
tianleh
as code owners
peterzhuamazon
approved these changes
Jan 13, 2025
zelinh
reviewed
Jan 13, 2025
| @@ -3,15 +3,15 @@ name: manifests-ci-check | |||
|
|
|||
| on: | |||
| pull_request: | |||
| types: [labeled, synchronize] | |||
| types: [opened, synchronize] | |||
| paths: | |||
| - 'manifests/**/*.yml' | |||
| - '!manifests/templates/**/' | |||
| - 'legacy-manifests/**/*.yml' | |||
There was a problem hiding this comment.
Maybe we can remove this line? Since it's in legacy-manifest folder, we shouldn't modify any of the existing manifests. We will be only move manifests to the legacy folder right?
There was a problem hiding this comment.
Right but incase we move files from manifest to legacy, the checks will also test for validations. Example, all tags exists and manifests are valid.
zelinh
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the conditional check to see if the label is present in the given PR. Adding a label was manual overhead and is often missed. Also if the event is PR synchronize
github.event.label.namecondition is never met. Example: #5233Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.