Add target_index_settings to rollup specification

[MrChaos1993]

Description

Allow to create index with specified settings during rollup

Issues Resolved

opensearch-project/index-management#1376

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[dblock]

@MrChaos1993 amend your commit with -s to pass DCO

Exercise an API in a test that returns this data, see https://github.com/opensearch-project/opensearch-api-specification/blob/main/TESTING_GUIDE.md

[github-actions]

Changes Analysis

Commit SHA: 9fa1c39
Comparing To SHA: fcbfc10

API Changes

Summary

└─┬Components
  └─┬rollups._common___Rollup
    └──[➕] properties (61280:9)

Document Element	Total Changes	Breaking Changes
components	1	0

• Total Changes: 1
• Additions: 1

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/13589491531/artifacts/2672475557

API Coverage

	Before	After	Δ
Covered (%)	663 (64.94 %)	663 (64.94 %)	0 (0 %)
Uncovered (%)	358 (35.06 %)	358 (35.06 %)	0 (0 %)
Unknown	45	45	0

[nhtruong]

Test suites that involve the new test failed with Expected status 201, but received 400: application/json. Invalid field [target_index_settings] found in Rollup.

Don't forget to add a line in the CHANGELOG.md describing the change from this PR.

[MrChaos1993]

Hi @nhtruong!
Could you please review this again?

[nhtruong]

We still get this error Invalid field [target_index_settings] found in Rollup. in the test suite against OS 3.0.0
Was target_index_settings added to 3.0.0? Or was it added to a later/unreleased version?

[MrChaos1993]

It was merged to main branch (Link to PR) and require version 3.0.0 or above.
I am not sure is it released or not, could you please help me?

[nhtruong]

@MrChaos1993 That looks like it belongs to an unreleased version of the index-management plugin.

@dblock correct me if I'm wrong but we only have the capability to test against unreleased OpenSearch right now. And It's too complicated to setup a cluster with unreleased plugins. So, in that case, we should this PR on hold for now?

[dblock]

@dblock correct me if I'm wrong but we only have the capability to test against unreleased OpenSearch right now. And It's too complicated to setup a cluster with unreleased plugins. So, in that case, we should this PR on hold for now?

You could use an unreleased version of the plugin too by installing the specific build in the container, but unsure it's worth it.

[nhtruong]

@dblock correct me if I'm wrong but we only have the capability to test against unreleased OpenSearch right now. And It's too complicated to setup a cluster with unreleased plugins. So, in that case, we should this PR on hold for now?

You could use an unreleased version of the plugin too by installing the specific build in the container, but unsure it's worth it.

I don't think it's worth it to set it up per PR like this, just to remove it once the new version of the plugin is released. Let's wait, @MrChaos1993. Sorry we don't have a more elegant solution for this right now. I've created a new label for this type of PRs.

[MrChaos1993]

@dblock correct me if I'm wrong but we only have the capability to test against unreleased OpenSearch right now. And It's too complicated to setup a cluster with unreleased plugins. So, in that case, we should this PR on hold for now?

You could use an unreleased version of the plugin too by installing the specific build in the container, but unsure it's worth it.

I don't think it's worth it to set it up per PR like this, just to remove it once the new version of the plugin is released. Let's wait, @MrChaos1993. Sorry we don't have a more elegant solution for this right now. I've created a new label for this type of PRs.

Sure, no problem!
I just wondering about missing specification for the new field, so If it's better to wait until release a newer version of plugin I totally agree.
Only one question should I tag someone when a newer version of the plugin will be released, or you will merge\restart check on your own?