Target Index Settings if create index during rollup #1377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrChaos1993
requested review from
bowenlan-amzn,
Hailong-am,
vikasvb90,
tandonks,
shiv0408 and
soosinha
as code owners
MrChaos1993
force-pushed
the
feat/rollup-index-settings
branch
3 times, most recently
from
eedafdc to
e08fb88
Compare
Signed-off-by: Aleksandr Tuliakov <tulyakov@yandex-team.ru>
Signed-off-by: Aleksandr Tuliakov <tulyakov@yandex-team.ru>
Signed-off-by: Aleksandr Tuliakov <tulyakov@yandex-team.ru>
MrChaos1993
force-pushed
the
feat/rollup-index-settings
branch
from
e08fb88 to
5ed6c6d
Compare
|
Hi! |
src/main/kotlin/org/opensearch/indexmanagement/rollup/model/Rollup.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/opensearch/indexmanagement/rollup/model/Rollup.kt
Outdated
Show resolved
Hide resolved
src/test/kotlin/org/opensearch/indexmanagement/rollup/model/RollupTests.kt
Outdated
Show resolved
Hide resolved
src/test/kotlin/org/opensearch/indexmanagement/rollup/TestHelpers.kt
Outdated
Show resolved
Hide resolved
src/test/kotlin/org/opensearch/indexmanagement/indexstatemanagement/action/RollupActionIT.kt
Show resolved
Hide resolved
src/test/kotlin/org/opensearch/indexmanagement/rollup/runner/RollupRunnerIT.kt
Show resolved
Hide resolved
src/main/kotlin/org/opensearch/indexmanagement/rollup/model/ISMRollup.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/opensearch/indexmanagement/rollup/model/ISMRollup.kt
Outdated
Show resolved
Hide resolved
Sure, here is the issue opensearch-project/index-management-dashboards-plugin#1275. I'll try to implement it during this week. |
Signed-off-by: Aleksandr Tuliakov <tulyakov@yandex-team.ru>
MrChaos1993
force-pushed
the
feat/rollup-index-settings
branch
from
611c7cd to
96302ac
Compare
Signed-off-by: Aleksandr Tuliakov <tulyakov@yandex-team.ru>
src/test/kotlin/org/opensearch/indexmanagement/rollup/TestHelpers.kt
Outdated
Show resolved
Hide resolved
…ers.kt Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
bowenlan-amzn
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add optional field
target_index_settingsto rollup job.Related Issues
Resolves #1376
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.