-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trace Groups Optimization - Remove duplicate filters #2368
Conversation
Signed-off-by: Adam Tackett <tackadam@amazon.com>
…board content Signed-off-by: Adam Tackett <tackadam@amazon.com>
Signed-off-by: Adam Tackett <tackadam@amazon.com>
Just one issue when we click on number of traces from the traceGroup table, filter doesn't pushed down to tracegroup table Only the traces table is updated. Not sure if this is an existing bug. Also, opening the tracegroup table reloads the trace table. This is the call that we wanted to remove I believe |
Signed-off-by: Adam Tackett <tackadam@amazon.com>
TraceGroup not triggering the re-load confirmed offline and in attached videos. Number of traces not filtering when clicked was an existing but that I just added a fix for
Dashboards was previously a seperate page so the re-direction flag was causing it to not refresh. |
* trace group opt, remove duplicate filter calls Signed-off-by: Adam Tackett <tackadam@amazon.com> * add back validation for traces and services, keep it removed for dashboard content Signed-off-by: Adam Tackett <tackadam@amazon.com> * remove spacing Signed-off-by: Adam Tackett <tackadam@amazon.com> * fix bug for filter applied from trace group Signed-off-by: Adam Tackett <tackadam@amazon.com> --------- Signed-off-by: Adam Tackett <tackadam@amazon.com> Co-authored-by: Adam Tackett <tackadam@amazon.com> (cherry picked from commit b84c5db) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* trace group opt, remove duplicate filter calls * add back validation for traces and services, keep it removed for dashboard content * remove spacing * fix bug for filter applied from trace group --------- (cherry picked from commit b84c5db) Signed-off-by: Adam Tackett <tackadam@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Adam Tackett <tackadam@amazon.com>
Description
https://github.com/opensearch-project/dashboards-observability/blob/main/public/components/trace_analytics/components/common/filters/filters.tsx#L79
and by the trace content page itself.
Removing these unnecessary filter settings led the queries to stop firing unnecessarily when opening the trace group panel.
Before (7 Queries (2 unnecessary))
After (5 Queries)

Filter behavior before:
BeforeFilter.mov
After (unchanged with code removal):
AfterFilterStillWorking.mov
Before.mov
After (filter applied):
After.mov
Issues Resolved
#2334 - Trace Group Optimizations
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.