Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Trace Groups Optimization - Remove duplicate filters #2373

Merged
merged 1 commit into from
Mar 5, 2025
Merged

[Backport 2.x] Trace Groups Optimization - Remove duplicate filters #2373

merged 1 commit into from
Mar 5, 2025

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport b84c5db from #2368.

@github-actions
Trace Groups Optimization - Remove duplicate filters (#2368)
5a8a439 
* trace group opt, remove duplicate filter calls

Signed-off-by: Adam Tackett <tackadam@amazon.com>

* add back validation for traces and services, keep it removed for dashboard content

Signed-off-by: Adam Tackett <tackadam@amazon.com>

* remove spacing

Signed-off-by: Adam Tackett <tackadam@amazon.com>

* fix bug for filter applied from trace group

Signed-off-by: Adam Tackett <tackadam@amazon.com>

---------

Signed-off-by: Adam Tackett <tackadam@amazon.com>
Co-authored-by: Adam Tackett <tackadam@amazon.com>
(cherry picked from commit b84c5db)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@TackAdam TackAdam added the bug Something isn't working label Mar 4, 2025
@TackAdam TackAdam merged commit 25d8f42 into 2.x Mar 5, 2025
14 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ps48 ps48 ps48 approved these changes

@TackAdam TackAdam TackAdam approved these changes

@kavithacm kavithacm Awaiting requested review from kavithacm kavithacm is a code owner

@derek-ho derek-ho Awaiting requested review from derek-ho derek-ho is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@dai-chen dai-chen Awaiting requested review from dai-chen dai-chen is a code owner

@YANG-DB YANG-DB Awaiting requested review from YANG-DB YANG-DB is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@Swiddis Swiddis Awaiting requested review from Swiddis Swiddis is a code owner

@penghuo penghuo Awaiting requested review from penghuo penghuo is a code owner

@seankao-az seankao-az Awaiting requested review from seankao-az seankao-az is a code owner

@anirudha anirudha Awaiting requested review from anirudha anirudha is a code owner

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ps48 @TackAdam