Block simulate API calls if datasource version is missing #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohltyler
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
amitgalitz,
jackiehanyang,
minalsha and
saimedhi
as code owners
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
saimedhi
approved these changes
Mar 4, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 4, 2025
* Block simulate on ingest if version not foundg Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * more cleanup after rebase Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Add checks in all modals Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Set defaults for calls of getEffectiveVesion Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * rename fn Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> --------- Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> (cherry picked from commit 1d0fea7) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
saimedhi
pushed a commit
that referenced
this pull request
Mar 4, 2025
* Block simulate on ingest if version not foundg * more cleanup after rebase * Add checks in all modals * Set defaults for calls of getEffectiveVesion * rename fn --------- (cherry picked from commit 1d0fea7) Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If there is a datasource ID, but no known version found, we cannot guarantee that the simulate API will be available. This PR adds a reusable custom hook to check for that scenario, and adds conditional checks for all places where
simulatePipeline()is called:WorkflowInputscomponentTo make this work,
getEffectiveVersion()was updated slightly to returnundefinedinstead of defaulting to the minimum version, since this undefined/empty case now needs to be handled. Audited all places wheregetEffectiveVersionis called, where a minimum version is wanted, and updated there. Updated the name togetDataSourceVersion()to reflect this more clearly as well.Also moves datasource-related logic into custom hooks for readability and reusability.
Also removes unnecessary '- required' text on quick config required fields to follow consistent pattern.
Testing
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.