Block simulate on ingest if version not foundg

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>

Author: ohltyler

public/pages/workflow_detail/workflow_inputs/workflow_inputs.tsx

@@ -60,6 +60,7 @@ import {
   getIngestPipelineErrors,
   getEffectiveVersion,
   sleep,
+  useMissingDataSourceVersion,
 } from '../../../utils';
 import { BooleanField } from './input_fields';
 import '../workspace/workspace-styles.scss';
@@ -116,6 +117,10 @@ export function WorkflowInputs(props: WorkflowInputsProps) {
     dataSourceVersion !== undefined
       ? semver.lt(dataSourceVersion, MINIMUM_FULL_SUPPORTED_VERSION)
       : false;
+  const missingDataSourceVersion = useMissingDataSourceVersion(
+    dataSourceId,
+    dataSourceVersion
+  );
 
   // transient running states
   const [isUpdatingSearchPipeline, setIsUpdatingSearchPipeline] = useState<
@@ -617,7 +622,10 @@ export function WorkflowInputs(props: WorkflowInputsProps) {
           if (
             !isEmpty(values?.ingest?.enrich) &&
             values?.ingest?.pipelineName !== undefined &&
-            values?.ingest?.pipelineName !== ''
+            values?.ingest?.pipelineName !== '' &&
+            // if the data source version is missing/undefined, we cannot
+            // guarantee that the simulate API will be available
+            !missingDataSourceVersion
           ) {
             const curDocs = prepareDocsForSimulate(
               values?.ingest?.docs,

public/utils/utils.tsx

@@ -3,7 +3,7 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-import React, { ReactNode } from 'react';
+import React, { ReactNode, useEffect, useState } from 'react';
 import yaml from 'js-yaml';
 import jsonpath from 'jsonpath';
 import { capitalize, escape, findKey, get, isEmpty, set, unset } from 'lodash';
@@ -159,27 +159,38 @@ export function isValidWorkflow(workflowObj: any): boolean {
 
 // Determines if a file used for import workflow is compatible with the current data source version.
 export async function isCompatibleWorkflow(
-  workflowObj: any, 
+  workflowObj: any,
   dataSourceId?: string | undefined
 ): Promise<boolean> {
   const compatibility = workflowObj?.version?.compatibility;
 
   // Default to true when compatibility cannot be assessed (empty/invalid compatibility array or MDS disabled.)
-  if (!Array.isArray(compatibility) || compatibility.length === 0 || dataSourceId === undefined) {
+  if (
+    !Array.isArray(compatibility) ||
+    compatibility.length === 0 ||
+    dataSourceId === undefined
+  ) {
     return true;
   }
 
-  const dataSourceVersion = await getEffectiveVersion(dataSourceId);  
-  const [effectiveMajorVersion, effectiveMinorVersion] = dataSourceVersion.split('.').map(Number);
-  
+  const dataSourceVersion = await getEffectiveVersion(dataSourceId);
+  const [
+    effectiveMajorVersion,
+    effectiveMinorVersion,
+  ] = dataSourceVersion.split('.').map(Number);
+
   // Checks if any version in compatibility array matches the current dataSourceVersion (major.minor)
-  return compatibility.some(compatibleVersion => {
-    const [compatibleMajor, compatibleMinor] = compatibleVersion.split('.').map(Number);
-    return effectiveMajorVersion === compatibleMajor && effectiveMinorVersion === compatibleMinor;
+  return compatibility.some((compatibleVersion) => {
+    const [compatibleMajor, compatibleMinor] = compatibleVersion
+      .split('.')
+      .map(Number);
+    return (
+      effectiveMajorVersion === compatibleMajor &&
+      effectiveMinorVersion === compatibleMinor
+    );
   });
 }
 
-
 export function isValidUiWorkflow(workflowObj: any): boolean {
   return (
     isValidWorkflow(workflowObj) &&
@@ -909,13 +920,13 @@ export function getFieldValue(jsonObj: {}, fieldName: string): any | undefined {
   return undefined;
 }
 
-// Get the version from the selected data source
+// Get the version from the selected data source, if found
 export const getEffectiveVersion = async (
   dataSourceId: string | undefined
-): Promise<string> => {
+): Promise<string | undefined> => {
   try {
     if (dataSourceId === undefined) {
-      throw new Error('Data source is required');
+      throw new Error();
     }
 
     if (dataSourceId === '') {
@@ -927,16 +938,26 @@ export const getEffectiveVersion = async (
       'data-source',
       dataSourceId
     );
-    const version =
-      dataSource?.attributes?.dataSourceVersion || MIN_SUPPORTED_VERSION;
-    return version;
+    return dataSource?.attributes?.dataSourceVersion;
   } catch (error) {
-    console.error('Error getting version:', error);
-    return MIN_SUPPORTED_VERSION;
+    console.error('Error getting version: ', error);
+    return undefined;
   }
 };
 
-    
+export function useMissingDataSourceVersion(
+  dataSourceId: string | undefined,
+  dataSourceVersion: string | undefined
+): boolean {
+  const [missingVersion, setMissingVersion] = useState<boolean>(false);
+  useEffect(() => {
+    setMissingVersion(
+      dataSourceId !== undefined && dataSourceVersion === undefined
+    );
+  }, [dataSourceId, dataSourceVersion]);
+  return missingVersion;
+}
+
 /**
  * Formats version string to show only major.minor numbers
  * Example: "3.0.0-alpha1" -> "3.0"
@@ -946,4 +967,3 @@ export function formatDisplayVersion(version: string): string {
   const [major, minor] = version.split('.');
   return `${major}.${minor}`;
 }
-