Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding span for invoke agent #1900
base: main
Are you sure you want to change the base?
Adding span for invoke agent #1900
Changes from all commits
f4d2958
10a8721
fa6d0e0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this attribute (or
gen_ai.request.choice.count
) applies to create_agent span - it seems one of the latest commits has added a lot of common attributes that aren't relevant oncreate_agent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When create agent, some request parameters can be specified, and
gen_ai.request.choice.count
is just one of the parameter for request, can you elaborate more why this cannot apply to agent creation?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have you seen any agent that supports max tokens or number of choices config at creation time? For steps/completion - sure, but when creating the agent?
I don't see them for bedrock, OpenAI assistants, Azure AI Agents won't have them.
I could not find them for client-side agents (llamaindex, langraph) either.
So if none of known agents has these parameters, let's not mention them here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lmolkova thanks, I think we may need a follow up PR for this, as you can see from https://github.com/open-telemetry/semantic-conventions/pull/1900/files#diff-5183ed68de81fe666274b64e46e9c3f9fc6ea6c358abd6f9b3b3f9cb3f1c7a13 , and the markdown file is generated automatically, can I fix this in a follow up PR?