Adding span for invoke agent #1900
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gyliu513 this needs rebase after the experimental -> development rename |
lmolkova
reviewed
Feb 13, 2025
gyliu513
force-pushed
the
invoke
branch
3 times, most recently
from
1af7a29 to
b704514
Compare
|
@lmolkova I think I have addressed all comments here, can you help review again? Thanks! |
lmolkova
reviewed
Mar 4, 2025
lmolkova
reviewed
Mar 4, 2025
docs/gen-ai/gen-ai-agent-spans.md
Outdated
|
|
||
| The `gen_ai.operation.name` SHOULD be `invoke_agent`. | ||
|
|
||
| The **span name** SHOULD be `invoke_agent {gen_ai.agent.name}`. |
There was a problem hiding this comment.
since gen_ai.agent.name is rarely available for remote agents, I think we need to change it to
Suggested change
| The **span name** SHOULD be `invoke_agent {gen_ai.agent.name}`. | |
| The **span name** SHOULD be `invoke_agent {gen_ai.agent.name}` if `gen_ai.agent.name` is readily available. When `gen_ai.agent.name` is not available, it SHOULD be `invoke_agent`. |
lmolkova
reviewed
Mar 4, 2025
gyliu513
force-pushed
the
invoke
branch
4 times, most recently
from
ea49e28 to
ef12e19
Compare
lmolkova
reviewed
Mar 7, 2025
docs/gen-ai/gen-ai-agent-spans.md
Outdated
| @@ -47,22 +48,120 @@ Semantic conventions for individual GenAI systems and frameworks MAY specify dif | |||
| |---|---|---|---|---|---| | |||
| | [`gen_ai.operation.name`](/docs/attributes-registry/gen-ai.md) | string | The name of the operation being performed. [1] | `chat`; `text_completion`; `embeddings` | `Required` |  | | |||
| | [`gen_ai.system`](/docs/attributes-registry/gen-ai.md) | string | The Generative AI product as identified by the client or server instrumentation. [2] | `openai` | `Required` |  | | |||
| | [`error.type`](/docs/attributes-registry/error.md) | string | Describes a class of error the operation ended with. [3] | `timeout`; `java.net.UnknownHostException`; `server_certificate_invalid`; `500` | `Conditionally Required` if the operation ended in an error |  | | |||
| | [`server.port`](/docs/attributes-registry/server.md) | int | GenAI server port. [4] | `80`; `8080`; `443` | `Conditionally Required` If `server.address` is set. |  | | ||
| | [`gen_ai.request.encoding_formats`](/docs/attributes-registry/gen-ai.md) | string[] | The encoding formats requested in an embeddings operation, if specified. [5] | `["base64"]`; `["float", "binary"]` | `Recommended` |  | | ||
| | [`gen_ai.request.frequency_penalty`](/docs/attributes-registry/gen-ai.md) | double | The frequency penalty setting for the GenAI request. | `0.1` | `Recommended` |  | | ||
| | [`gen_ai.request.max_tokens`](/docs/attributes-registry/gen-ai.md) | int | The maximum number of tokens the model generates for a request. | `100` | `Recommended` |  | |
There was a problem hiding this comment.
I don't think this attribute (or gen_ai.request.choice.count) applies to create_agent span - it seems one of the latest commits has added a lot of common attributes that aren't relevant on create_agent
There was a problem hiding this comment.
When create agent, some request parameters can be specified, and gen_ai.request.choice.count is just one of the parameter for request, can you elaborate more why this cannot apply to agent creation?
Signed-off-by: Guangya Liu <gyliu@ibm.com>
|
@lmolkova can you help review this again? The major change is in https://github.com/open-telemetry/semantic-conventions/pull/1900/files#diff-5183ed68de81fe666274b64e46e9c3f9fc6ea6c358abd6f9b3b3f9cb3f1c7a13 and other files are auto generated, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1842 #1924
Changes
Please provide a brief description of the changes here.
Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.
Merge requirement checklist
[chore]