Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i18n] Separate prose out of Convert docs/exporter/intro.md, and other improvements #6583

Merged

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Mar 20, 2025

Previews

Diff

There is no significant change to the generated site files:

$ (cd public && git diff -I "dateModified|modified_time|data-proofer|^\s+[0-9a-f]+\.\.[0-9a-f]+</a>" -- ':(exclude)*.xml') | grep ^diff
diff --git a/site/index.html b/site/index.html

The last regex alternative of the argument to git diff -I is so that we ignore the "This page has drifted" callout's GitHub diff URL, which has changed.

@chalin chalin added CI/infra CI & infrastructure i18n Internationalization and localization labels Mar 20, 2025
@chalin chalin requested a review from a team as a code owner March 20, 2025 20:03
@opentelemetrybot opentelemetrybot requested a review from a team March 20, 2025 20:03
@opentelemetrybot opentelemetrybot requested a review from a team March 20, 2025 20:03
@opentelemetrybot opentelemetrybot requested a review from a team March 20, 2025 20:03
@opentelemetrybot opentelemetrybot requested a review from a team March 20, 2025 20:03
@opentelemetrybot opentelemetrybot requested review from a team March 20, 2025 20:03
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content of this file is essentially the prose that was in the old version of layouts/shortcodes/docs/languages/exporters/intro.md.

@chalin chalin force-pushed the chalin-im-exporter-intro-2025-03-20 branch 2 times, most recently from 22f6cc6 to f75e710 Compare March 20, 2025 20:11
@chalin chalin force-pushed the chalin-im-exporter-intro-2025-03-20 branch from f75e710 to 038ce40 Compare March 20, 2025 20:21
Copy link
Contributor

@tiffany76 tiffany76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM.

Co-authored-by: Tiffany Hrabusa <30397949+tiffany76@users.noreply.github.com>
@opentelemetrybot opentelemetrybot requested a review from a team March 20, 2025 23:23
Copy link
Member

@theletterf theletterf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT.

Tangentially related question: Do we hash includes and track them for localization drift?

@chalin
Copy link
Contributor Author

chalin commented Mar 21, 2025

Tangentially related question: Do we hash includes and track them for localization drift?

Yes, given that the include pages are under content, they get checked by our i18n check script to ensure that they get tagged, and any drift is reported by the script. (I don't have a mechanism to have the drift notice show up on the website when due to drifted includes. I'll have to think about that.)

@chalin chalin added this pull request to the merge queue Mar 21, 2025
Merged via the queue into open-telemetry:main with commit 5db74ea Mar 21, 2025
18 checks passed
@chalin chalin deleted the chalin-im-exporter-intro-2025-03-20 branch March 21, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants