-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[i18n] Separate prose out of Convert docs/exporter/intro.md, and other improvements #6583
[i18n] Separate prose out of Convert docs/exporter/intro.md, and other improvements #6583
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The content of this file is essentially the prose that was in the old version of layouts/shortcodes/docs/languages/exporters/intro.md
.
22f6cc6
to
f75e710
Compare
f75e710
to
038ce40
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSLGTM.
Co-authored-by: Tiffany Hrabusa <30397949+tiffany76@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT.
Tangentially related question: Do we hash includes and track them for localization drift?
Yes, given that the include pages are under |
docs/latest-release
#6460layouts/shortcodes/docs/languages/exporters/intro.md
shortcode, pulling out all the prose and putting it in an include file. We're still using the shortcode, because there's some logic in there used to initialize variables.Previews
Diff
There is no significant change to the generated site files:
The last regex alternative of the argument to
git diff -I
is so that we ignore the "This page has drifted" callout's GitHub diff URL, which has changed.