Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i18n] In computing page drift, consider parts from shortcodes and included pages? #6594

Open
chalin opened this issue Mar 21, 2025 · 0 comments
Labels
CI/infra CI & infrastructure i18n Internationalization and localization

Comments

@chalin
Copy link
Contributor

chalin commented Mar 21, 2025

Originally posted by @chalin in #6583 (comment):

Tangentially related question: Do we hash includes and track them for localization drift?

Yes, given that the include pages are under content, they get checked by our i18n check script to ensure that they get tagged, and any drift is reported by the script. (I don't have a mechanism to have the drift notice show up on the website when due to drifted includes. I'll have to think about that.)

Page parts might be included via shortcodes, as was done in #6583, or include statements. Not sure it's worth the effort, but if we can find a simple solution, that would be great.

@chalin chalin added CI/infra CI & infrastructure i18n Internationalization and localization labels Mar 21, 2025
@chalin chalin changed the title [i18n] Consider included pages in page-drift [i18n] In computing page drift, consider parts from shortcodes and included pages? Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/infra CI & infrastructure i18n Internationalization and localization
Projects
Status: No status
Development

No branches or pull requests

1 participant