-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: Baggage insert & BaggageExt::with_baggage & updated constants to latest standard #2284
Conversation
9c71657
to
66cd5f7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2284 +/- ##
=====================================
Coverage 79.4% 79.4%
=====================================
Files 123 123
Lines 22748 22736 -12
=====================================
- Hits 18063 18058 -5
+ Misses 4685 4678 -7 ☔ View full report in Codecov by Sentry. |
a20d014
to
8438828
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Would be good to add a changelog entry for the fixes in size/length validations fixes.
Will open separate issue to make Baggage spec compliant.
91eef2f
to
5efb903
Compare
…& updated constants to the latest standard
5efb903
to
cc7cd67
Compare
Changes
Improve few things:
BaggageExt::with_baggage
now "clone" baggage, instead of iterate+collect.Baggage::insert_with_metadata
(used everywhere) should be a bit faster, as it had redundant calculations:Baggage::iter
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes