Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change value type of Baggage to StringValue #2729

Merged
merged 2 commits into from
Mar 1, 2025

Conversation

gruebel
Copy link
Member

@gruebel gruebel commented Feb 27, 2025

Fixes #2716

Changes

  • I had to make it a breaking change, I don't think it is possible to do it via deprecation

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@gruebel gruebel requested a review from a team as a code owner February 27, 2025 22:38
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 83.78378% with 6 lines in your changes missing coverage. Please review.

Project coverage is 79.4%. Comparing base (91ae096) to head (c0fe22c).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry/src/baggage.rs 64.7% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #2729     +/-   ##
=======================================
- Coverage   79.4%   79.4%   -0.1%     
=======================================
  Files        123     123             
  Lines      22737   22748     +11     
=======================================
+ Hits       18060   18063      +3     
- Misses      4677    4685      +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gruebel gruebel closed this Feb 28, 2025
@gruebel gruebel reopened this Feb 28, 2025
@cijothomas
Copy link
Member

@gruebel Thanks for addressing this!
@fraillt has made a few perf improvements and bug fixes to this, but unfortunately that was not merged
#2284

I agree it is not possible to do this without breaking, so let's do it. I also think we should make sure we can review Baggage entirely and finish up all breaking changes (if any) before next release, and mark Baggage also as RC status, preventing further breaking changes to it.

@gruebel
Copy link
Member Author

gruebel commented Feb 28, 2025

Oh nice, didn't see that PR. I can wait till his changes are merged and then rebase my afterwards or vice versa.

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Its breaking change, but necessary cost to take to get to stable.

@cijothomas cijothomas merged commit 5e47487 into open-telemetry:main Mar 1, 2025
23 checks passed
@cijothomas
Copy link
Member

Oh nice, didn't see that PR. I can wait till his changes are merged and then rebase my afterwards or vice versa.

Merged this one first as this is affecting public API and want to get Baggage towards stable/rc by next release.
@fraillt Could you resubmit the PR for perf improvements in Baggage?

Apologies for the delay - I was focused on Logs/Metrics and only now had bandwidth to look at Baggage!

@gruebel gruebel deleted the change-baggage-value branch March 1, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Baggage - Keys and Values should be strings
2 participants