Remove isahc support
#1924
Merged
Remove isahc support
#1924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1924 +/- ##
=====================================
Coverage 75.0% 75.0%
=====================================
Files 122 122
Lines 20289 20276 -13
=====================================
+ Hits 15221 15222 +1
+ Misses 5068 5054 -14 ☔ View full report in Codecov by Sentry. |
mladedav
reviewed
Jul 10, 2024
4 tasks
TommyCpp
approved these changes
Jul 10, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
isahcas part of the http v1 upgrade (see #1674 (comment))Changes
Breaking change: Remove the
isahcclient fromopentelemetry-http. Progress on that client has been pretty much non-existent lately and is therefore stuck on http v0.2.In preparation for the upgrade, we need to remove that client first since supporting it, while possible, would add a maintainance burden in form of the compatibility layer.
Also the author has mentioned that they are attempting to pick up development again, meaning as soon as it reaches support for v1, it can be added again (it's not a lot of code tbh)
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes