-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When deserializing JSON, accept both int and string in 'intValue' #1906
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1906 +/- ##
=======================================
- Coverage 74.9% 74.9% -0.1%
=======================================
Files 122 122
Lines 20311 20311
=======================================
- Hits 15217 15216 -1
- Misses 5094 5095 +1 ☔ View full report in Codecov by Sentry. |
@RazvanRotari Thanks for the PR. Can you also add tests to validate this? There are some relevant unit-tests here - test_serde if that helps. |
@lalitb Modified |
@lalitb Hi guys, any updates on this? We also have encountered this problem. |
@lalitb @cijothomas Looks like the latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @RazvanRotari . Nicely done. LGTM.
I think it was fixed in #1924 |
Fixes #1905
Design discussion issue (if applicable) #
Changes
When deserializing JSON, accept both int and string in 'intValue' field of AnyValue.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes