Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update msrv check, and bump opentelemetry-proto to v1.70.0 #1864

Merged
merged 14 commits into from
Jun 6, 2024

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Jun 4, 2024

Changes

  • Update msrv for opentelemetry-proto to v1.70.0
  • Enable msrv check for opentelemetry-proto and opentelemetry-otlp
  • Modified the scripts/msrv.sh to be version agnostic. The package and version mapping is maintained in ./scripts/msrv_config.json.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@lalitb lalitb requested a review from a team June 4, 2024 18:52
@lalitb lalitb marked this pull request as draft June 4, 2024 18:52
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.5%. Comparing base (f1cdaca) to head (21f7264).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1864   +/-   ##
=====================================
  Coverage   74.5%   74.5%           
=====================================
  Files        122     122           
  Lines      19859   19859           
=====================================
  Hits       14808   14808           
  Misses      5051    5051           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lalitb
Copy link
Member Author

lalitb commented Jun 4, 2024

will reopen after fix.
Fixed now

@lalitb lalitb closed this Jun 4, 2024
@lalitb lalitb reopened this Jun 4, 2024
@lalitb lalitb marked this pull request as ready for review June 4, 2024 23:03
@cijothomas cijothomas merged commit 36ad46a into open-telemetry:main Jun 6, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants