Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTLPExporter msrv check in CI #1863

Closed
cijothomas opened this issue Jun 4, 2024 · 2 comments
Closed

OTLPExporter msrv check in CI #1863

cijothomas opened this issue Jun 4, 2024 · 2 comments
Labels
help wanted Good for taking. Extra help will be provided by maintainers/approvers

Comments

@cijothomas
Copy link
Member

https://github.com/open-telemetry/opentelemetry-rust/pull/1840/files has explicitly updgraded msrv for otlp exporter. But the CI check is not checking this for OTLP exporter now.

https://github.com/open-telemetry/opentelemetry-rust/blob/main/scripts/msrv.sh#L14-L17

Opening an issue to track adding the msrv check for otlp. It could be done via an env variable to control the version or other ideas are welcome.

@cijothomas cijothomas added the help wanted Good for taking. Extra help will be provided by maintainers/approvers label Jun 4, 2024
@lalitb
Copy link
Member

lalitb commented Jun 4, 2024

Do we need to bump msrv for opentelemetry-proto too, as that too depends on tonic and prost?

@cijothomas
Copy link
Member Author

closed via #1864

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Good for taking. Extra help will be provided by maintainers/approvers
Projects
None yet
Development

No branches or pull requests

2 participants