Small change to return error from periodic exporter #1857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1857 +/- ##
======================================
Coverage ? 74.5%
======================================
Files ? 122
Lines ? 19809
Branches ? 0
======================================
Hits ? 14761
Misses ? 5048
Partials ? 0 ☔ View full report in Codecov by Sentry. |
cijothomas
reviewed
Jun 3, 2024
cijothomas
approved these changes
Jun 3, 2024
cijothomas
reviewed
Jun 4, 2024
opentelemetry-sdk/CHANGELOG.md
Outdated
| @@ -45,6 +45,8 @@ | |||
|
|
|||
| - **Breaking** [1850] (https://github.com/open-telemetry/opentelemetry-rust/pull/1850) `LoggerProvider::log_processors()` and `LoggerProvider::resource()` are not public methods anymore. They are only used within the `opentelemetry-sdk` crate. | |||
|
|
|||
| - [1857](https://github.com/open-telemetry/opentelemetry-rust/pull/1857) Fixed an issue in the `collect_and_export()` method of the periodic exporter where errors during export were dropped, ensuring proper error handling and reporting. | |||
There was a problem hiding this comment.
collect_and_export() is not a public method. I'd suggest to phrase this in a way applicable to end users.
something like:
Fixed an issue in Metrics SDK which prevented export errors from being send to global error handler. With the fix, errors occurring during export like OTLP Endpoint unresponsive shows up in stderr by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The
collect_and_export()drops the error in case of failure during export, and always return success. Fixing that. Testing using end-to-end test for OTLP metrics exporter, with no collector running. Not adding the unit-test for now - can be done by creating a failing MockExporter (if required).Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes