Skip to content

Commit f488006

Browse files
lalitbcijothomas
andauthored
Small change to return error from periodic exporter (#1857)
Co-authored-by: Cijo Thomas <cijo.thomas@gmail.com>
1 parent 406cc31 commit f488006

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

opentelemetry-sdk/CHANGELOG.md

+2
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,8 @@
4545

4646
- **Breaking** [1850] (https://github.com/open-telemetry/opentelemetry-rust/pull/1850) `LoggerProvider::log_processors()` and `LoggerProvider::resource()` are not public methods anymore. They are only used within the `opentelemetry-sdk` crate.
4747

48+
- [1857](https://github.com/open-telemetry/opentelemetry-rust/pull/1857) Fixed an issue in Metrics SDK which prevented export errors from being send to global error handler. With the fix, errors occurring during export like OTLP Endpoint unresponsive shows up in stderr by default.
49+
4850
## v0.23.0
4951

5052
- Fix SimpleSpanProcessor to be consistent with log counterpart. Also removed

opentelemetry-sdk/src/metrics/periodic_reader.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,7 @@ impl<RT: Runtime> PeriodicReaderWorker<RT> {
260260
pin_mut!(timeout);
261261

262262
match future::select(export, timeout).await {
263-
Either::Left(_) => Ok(()),
263+
Either::Left((res, _)) => res, // return the result.
264264
Either::Right(_) => Err(MetricsError::Other("export timed out".into())),
265265
}
266266
}

0 commit comments

Comments
 (0)