Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove flaky tests #1727

Merged
merged 1 commit into from
May 9, 2024
Merged

chore: remove flaky tests #1727

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 0 additions & 35 deletions opentelemetry-jaeger/src/exporter/config/collector/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,43 +558,8 @@ impl CollectorPipeline {
#[cfg(test)]
#[cfg(feature = "rt-tokio")]
mod tests {
use opentelemetry_sdk::runtime::Tokio;

use crate::config::collector::http_client::test_http_client;

use super::*;

#[test]
fn test_set_collector_endpoint() {
let invalid_uri = new_collector_pipeline()
.with_endpoint("127.0.0.1:14268/api/traces")
.with_http_client(test_http_client::TestHttpClient)
.build_uploader::<Tokio>();
assert!(invalid_uri.is_err());
assert_eq!(
format!("{:?}", invalid_uri.err().unwrap()),
"ConfigError { pipeline_name: \"collector\", config_name: \"collector_endpoint\", reason: \"invalid uri from the builder, invalid format\" }",
);

let valid_uri = new_collector_pipeline()
.with_http_client(test_http_client::TestHttpClient)
.with_endpoint("http://127.0.0.1:14268/api/traces")
.build_uploader::<Tokio>();

assert!(valid_uri.is_ok());
}

// Ignore this test as it is flaky and the opentelemetry-jaeger is on-track for deprecation
#[ignore]
#[test]
fn test_collector_exporter() {
let exporter = new_collector_pipeline()
.with_endpoint("http://127.0.0.1:14268/api/traces")
.with_http_client(test_http_client::TestHttpClient)
.build_collector_exporter::<Tokio>();
assert!(exporter.is_ok());
}

#[test]
fn test_resolve_endpoint() {
struct TestCase<'a> {
Expand Down
Loading