Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove flaky tests #1727

Merged
merged 1 commit into from
May 9, 2024
Merged

chore: remove flaky tests #1727

merged 1 commit into from
May 9, 2024

Conversation

TommyCpp
Copy link
Contributor

@TommyCpp TommyCpp commented May 9, 2024

Changes

  • remove two flaky tests as they are part of a deprecated create and has been causing issues for us

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

lalitb
lalitb approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I was trying to fix it other day, but removal is better :)

@TommyCpp TommyCpp marked this pull request as ready for review May 9, 2024 03:06
@TommyCpp TommyCpp requested a review from a team May 9, 2024 03:06
@cijothomas cijothomas merged commit 8f8c259 into open-telemetry:main May 9, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lalitb lalitb lalitb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TommyCpp @lalitb @cijothomas