Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI workflow to also run it on Windows #1703

Closed
wants to merge 2 commits into from
Closed

Update CI workflow to also run it on Windows #1703

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
459ae71
Update CI workflow
utpilla May 2, 2024
a61e7c3
Fix CI
utpilla May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,11 @@ jobs:
strategy:
matrix:
rust: [stable, beta]
runs-on: ubuntu-latest
os: [ windows-latest, ubuntu-latest ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need a separate job for Windows. The current job relies on quite a few bash scripts (lint.sh, test.sh etc)

runs-on: ${{ matrix.os }}
steps:
- name: Free disk space
if: ${{ matrix.os == 'ubuntu-latest'}}
run: |
df -h
sudo rm -rf /usr/local/lib/android
Expand All @@ -34,7 +36,7 @@ jobs:
- name: Test
run: ./scripts/test.sh
lint:
runs-on: ubuntu-latest
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v4
with:
Expand All @@ -53,7 +55,7 @@ jobs:
strategy:
matrix:
example: [opentelemetry, opentelemetry-sdk, opentelemetry-otlp, opentelemetry-zipkin]
runs-on: ubuntu-latest
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@nightly
Expand All @@ -69,7 +71,7 @@ jobs:
strategy:
matrix:
example: [opentelemetry-otlp/examples/basic-otlp]
runs-on: ubuntu-latest
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v4
with:
Expand All @@ -83,7 +85,7 @@ jobs:
cd ${{ matrix.example }}
cargo build --verbose
msrv:
runs-on: ubuntu-latest
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v4
with:
Expand All @@ -97,7 +99,7 @@ jobs:
cargo test --manifest-path=opentelemetry-jaeger/Cargo.toml --features rt-tokio &&
cargo test --manifest-path=opentelemetry-zipkin/Cargo.toml
cargo-deny:
runs-on: ubuntu-latest
runs-on: ${{ matrix.os }}
continue-on-error: true # Prevent sudden announcement of a new advisory from failing ci
steps:
- uses: actions/checkout@v4
Expand All @@ -106,7 +108,7 @@ jobs:
command: check advisories
docs:
continue-on-error: true
runs-on: ubuntu-latest
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@nightly
Expand All @@ -120,7 +122,7 @@ jobs:
RUSTDOCFLAGS: -Dwarnings
coverage:
continue-on-error: true
runs-on: ubuntu-latest
runs-on: ${{ matrix.os }}
if: ${{ ! contains(github.event.pull_request.labels.*.name, 'dependencies') }}
steps:
- uses: actions/checkout@v4
Expand Down