Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI workflow to also run it on Windows #1703

Closed

Conversation

utpilla
Copy link
Contributor

@utpilla utpilla commented May 2, 2024

Changes

  • Update CI workflow to also run it on Windows

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@@ -13,7 +13,8 @@ jobs:
strategy:
matrix:
rust: [stable, beta]
runs-on: ubuntu-latest
os: [ windows-latest, ubuntu-latest ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need a separate job for Windows. The current job relies on quite a few bash scripts (lint.sh, test.sh etc)

@utpilla utpilla closed this May 2, 2024
@utpilla utpilla deleted the utpilla/Update-CI-workflow branch May 4, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants