Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore flaky opentelemetry-jaeger tests #1529

Merged
merged 3 commits into from
Feb 14, 2024
Merged

Ignore flaky opentelemetry-jaeger tests #1529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
34093a9
Ignore flaky opentelemetry-jaeger tests
mattbodd Feb 13, 2024
6d7c8bf
Leave comment to indicate why tests are ignored
mattbodd Feb 14, 2024
f6df258
Merge branch 'main' into ignore_flaky_opentelemetry_jaeger_tests
mattbodd Feb 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions opentelemetry-jaeger/src/exporter/config/collector/http_client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,8 @@ mod collector_client_tests {
use opentelemetry::trace::TraceError;
use opentelemetry_sdk::runtime::Tokio;

// Ignore this test as it is flaky and the opentelemetry-jaeger is on-track for deprecation
#[ignore]
#[test]
fn test_bring_your_own_client() -> Result<(), TraceError> {
let invalid_uri_builder = new_collector_pipeline()
Expand Down
2 changes: 2 additions & 0 deletions opentelemetry-jaeger/src/exporter/config/collector/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -571,6 +571,8 @@ mod tests {
assert!(valid_uri.is_ok());
}

// Ignore this test as it is flaky and the opentelemetry-jaeger is on-track for deprecation
#[ignore]
#[test]
fn test_collector_exporter() {
let exporter = new_collector_pipeline()
Expand Down
Loading