-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore flaky opentelemetry-jaeger tests #1529
Ignore flaky opentelemetry-jaeger tests #1529
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1529 +/- ##
=======================================
- Coverage 62.8% 62.5% -0.4%
=======================================
Files 144 144
Lines 19891 19891
=======================================
- Hits 12502 12433 -69
- Misses 7389 7458 +69 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this works.
The issue here is we didn't isolate the env vars between tests. A more robust fix probably is running jaeger tests in single thread.
Maybe we can ignore the jaeger in coverage tests?
yes. I think the easiest approach is to just ignore the tests, and do the jaeger release, followed by its code+tests removal. |
Thanks @TommyCpp and @cijothomas for your comments. As Cijo mentioned, since we are deprecating opentelemetry-jaeger I didn't opt to fix these flaky tests and instead just silenced them so CI doesn't fail. Is there anything I should do differently or can this change be merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let add a comment that says we ignore this because it's flaky and won't fix because jaeger has been deprecated
This is a good suggestion. I've left a comment above each ignored test. |
Fixes #1505
Two tests have been intermittently failing from the
opentelemetry-jaeger
crate:exporter::config::collector::http_client::collector_client_tests::test_bring_your_own_client
exporter::config::collector::tests::test_collector_exporter
As the
opentelemetry-jaeger
crate will be removed in the next major release, these tests can be ignored for the time being to alleviate the issue.Changes
Ignores tests:
exporter::config::collector::http_client::collector_client_tests::test_bring_your_own_client
exporter::config::collector::tests::test_collector_exporter
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes