Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Correct LoggingHookTest timestamp handling. #386

Merged
merged 1 commit into from
Feb 24, 2025
Merged

chore: Correct LoggingHookTest timestamp handling. #386

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions test/OpenFeature.Tests/Hooks/LoggingHookTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,12 +89,13 @@ public async Task BeforeAsync_With_EvaluationContext_Generates_Correct_Log_Messa

var clientMetadata = new ClientMetadata("client", "1.0.0");
var providerMetadata = new Metadata("provider");
var timestamp = DateTime.Parse("2025-01-01T11:00:00.0000000Z");
var evaluationContext = EvaluationContext.Builder()
.Set("key_1", "value")
.Set("key_2", false)
.Set("key_3", 1.531)
.Set("key_4", 42)
.Set("key_5", DateTime.Parse("2025-01-01T11:00:00.0000000Z"))
.Set("key_5", timestamp)
.Build();

var context = new HookContext<bool>("test", false, FlagValueType.Object, clientMetadata,
Expand All @@ -116,7 +117,7 @@ public async Task BeforeAsync_With_EvaluationContext_Generates_Correct_Log_Messa
() => Assert.Contains("key_2:False", record.Message),
() => Assert.Contains("key_3:1.531", record.Message),
() => Assert.Contains("key_4:42", record.Message),
() => Assert.Contains("key_5:2025-01-01T11:00:00.0000000+00:00", record.Message)
() => Assert.Contains($"key_5:{timestamp:O}", record.Message)
);
}

Expand Down Expand Up @@ -225,12 +226,14 @@ public async Task ErrorAsync_With_EvaluationContext_Generates_Correct_Log_Messag

var clientMetadata = new ClientMetadata("client", "1.0.0");
var providerMetadata = new Metadata("provider");

var timestamp = DateTime.Parse("2099-01-01T01:00:00.0000000Z");
var evaluationContext = EvaluationContext.Builder()
.Set("key_1", " ")
.Set("key_2", true)
.Set("key_3", 0.002154)
.Set("key_4", -15)
.Set("key_5", DateTime.Parse("2099-01-01T01:00:00.0000000Z"))
.Set("key_5", timestamp)
.Build();

var context = new HookContext<bool>("test", false, FlagValueType.Object, clientMetadata,
Expand All @@ -254,7 +257,7 @@ public async Task ErrorAsync_With_EvaluationContext_Generates_Correct_Log_Messag
() => Assert.Contains("key_2:True", record.Message),
() => Assert.Contains("key_3:0.002154", record.Message),
() => Assert.Contains("key_4:-15", record.Message),
() => Assert.Contains("key_5:2099-01-01T01:00:00.0000000+00:00", record.Message)
() => Assert.Contains($"key_5:{timestamp:O}", record.Message)
);
}

Expand Down