Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Correct LoggingHookTest timestamp handling. #386

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

kinyoklion
Copy link
Member

@kinyoklion kinyoklion commented Feb 23, 2025

This PR

While working on adding support for hook data I noticed unit tests only run correctly in a UTC+0 timezone.

This PR formats the timestamp to match how it will appear in the log.

Alternatively the logging hook could be changed to always output UTC.

Related Issues

Notes

Follow-up Tasks

How to test

Unit tests should pass when running in a non-UTC timezone.

Signed-off-by: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com>
@kinyoklion kinyoklion requested a review from a team as a code owner February 23, 2025 02:40
Copy link

codecov bot commented Feb 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.13%. Comparing base (9185b76) to head (df14862).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #386   +/-   ##
=======================================
  Coverage   86.13%   86.13%           
=======================================
  Files          39       39           
  Lines        1601     1601           
  Branches      173      173           
=======================================
  Hits         1379     1379           
  Misses        186      186           
  Partials       36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@beeme1mr beeme1mr added this pull request to the merge queue Feb 24, 2025
Merged via the queue into main with commit c69a6e5 Feb 24, 2025
16 checks passed
@askpt askpt deleted the rlamb/fix-timestamp-unit-test branch February 24, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants