Feature/tr 6452/vertical item layout #2669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Front-end summary Node 18
|
This was referenced Jan 29, 2025
This was referenced Feb 4, 2025
….com/oat-sa/extension-tao-itemqti into feature/TR-6448/vertical-inlinechoice
1 task
1 task
…dtext Feature/tr 6451/vertical extendedtext
Feature/tr 6450/vertical textentry
…b.com/oat-sa/extension-tao-itemqti into feature/TR-6449/vertical-writing-choice-interactions
This was referenced Feb 17, 2025
…-choice-interactions Feature/TR-6449/vertical writing for choiceInteraction
oatymart
approved these changes
Feb 19, 2025
There was a problem hiding this comment.
Works well.
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
- Pull request's target is not
master(ormain) - or is a release -
Bundled code is present if needed -
Version bump is applied if needed (packages AND root) - Commits are following conventional commits
- Commits messages are meaningful
- Commits are atomic
-
Changelog is updated according to changes (if applicable) - Documentation is updated according to changes (if applicable)
…hoice Feature/tr 6448/vertical inlinechoice
added 3 commits
February 19, 2025 18:12
….com/oat-sa/extension-tao-itemqti into feature/TR-6452/vertical-item-layout
…mqti into feature/TR-6452/vertical-item-layout
Version
There are 0 BREAKING CHANGE, 3 features, 12 fixes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://oat-sa.atlassian.net/browse/TR-6452
writing-mode: vertical-rlfor item, in Terre test-runner.Base branch for interaction tickets.
On unit01.
Layout ticket is not finished (image sizes, max-width, ...), let's just merge what we already have.
TODO:
tao-item-runner-qti-feRelated PRs: