Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/tr 6450/vertical textentry #2678

Conversation

olga-kulish
Copy link
Contributor

@olga-kulish olga-kulish commented Feb 6, 2025

Related to https://oat-sa.atlassian.net/browse/TR-6450

writing-mode: vertical-rl for TextEntryInteraction.

TODO:

  • update composer.json & package.json dependencies after related PR merged

Where to test:

see ticket comment

Related PRs:

@@ -51,6 +51,7 @@
line-height: 2.5;
border: 2px solid black;
padding: 5px;
margin: 0 5px;
margin-block: 0;
margin-inline: 5px;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In review mode (can switch renderer here):

Screenshot_77
Screenshot_74

@olga-kulish olga-kulish requested review from a team, oatymart and taopkorczak February 7, 2025 16:43
Copy link
Contributor

@taopkorczak taopkorczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

…dtext

Feature/tr 6451/vertical extendedtext
@olga-kulish olga-kulish merged commit 1044bae into feature/TR-6448/vertical-inlinechoice Feb 11, 2025
@olga-kulish olga-kulish deleted the feature/TR-6450/vertical-textentry branch February 11, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants