chore: replace hardcoded urls with RouteName enum #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onmax
force-pushed
the
onmax/route-name
branch
4 times, most recently
from
1757678 to
4afccb8
Compare
onmax
force-pushed
the
onmax/route-name
branch
from
4afccb8 to
91fffb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace all hardcoded paths with
RouteNameenum:$router.push('')->$router.push({ name: RouteName.XXX })$router.replace('')->$router.replace({ name: RouteName.XXX })I had some issues with the routes
/and/transactionsas it was giving me some issues in mobile.I decided to leave that out to not bother with that issue at the moment.
TODO
en.pofile (some lines changed), but I don't want to deal with merge conflicts. Better to do that before merging to master?