-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jeff/misc from sinpe branch #254
Conversation
@onmax Can you explain why the |
I introduced this because I often misspelled route names in the past. With TS, improve DX in both dev and building. However, I can undo it if you don't think it's worth it. In code looks like: router.push({ name: 'my-modal' }); // before
router.push({ name: RouteName.MyModal }); // after plus, this change does not break anything PS: Similar principle that you have commented before in one of my other PR |
Well, for now you just moved the string definition from inside the route object to outside. But are the route names also going to be replaced in other places? Only then it makes sense. |
See #255 |
Ah sorry, that's probably a mistake on my part, I didn't realized there was a commit where everything else got changed (I thought this was just going to be a partial migration kind of thing and then route names in other places would get changed whenever that code got changed in the future). |
Authored-By: Maxi <maximogarciamtnez@gmail.com>
This is not a breaking change, and it will help us ensure the string values are consistent across the app Authored-By: Maxi <maximogarciamtnez@gmail.com>
Authored-By: Maxi <maximogarciamtnez@gmail.com>
91fffb4
to
d8f88d1
Compare
More spin off commits from the sinpe branch.
The ones here are based on da0d25b, 8d9379a, 7a109ee and 663f583 without the sinpe movil specific parts.