-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Managed Deployments: Groups and Releases #1653
Open
nshoes
wants to merge
1
commit into
main
Choose a base branch
from
managed-deploys/deployment-groups-and-deployment-releases
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
[ | ||
{"lib/x509/certificate.ex", "Unknown type: X509.ASN1.record/1."}, | ||
{"lib/x509/certificate/extension.ex", "Unknown type: X509.ASN1.record/1."}, | ||
{"lib/nerves_hub/deployments/orchestrator.ex", :unmatched_return, 1}, | ||
{"lib/nerves_hub/managed_deployments/orchestrator.ex", :unmatched_return, 1}, | ||
{"lib/nerves_hub_web/channels/device_channel.ex", :unmatched_return, 1}, | ||
{"lib/nerves_hub_web/channels/device_socket.ex", :unmatched_return, 1} | ||
] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
47 changes: 47 additions & 0 deletions
47
lib/nerves_hub/audit_logs/templates/deployment_group_templates.ex
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
defmodule NervesHub.AuditLogs.DeploymentGroupTemplates do | ||
@moduledoc """ | ||
Templates for and handling of audit logging for deployment operations. | ||
""" | ||
alias NervesHub.Accounts.User | ||
alias NervesHub.AuditLogs | ||
alias NervesHub.Devices.Device | ||
alias NervesHub.ManagedDeployments.DeploymentGroup | ||
|
||
@spec audit_deployment_created(User.t(), DeploymentGroup.t()) :: :ok | ||
def audit_deployment_created(user, deployment_group) do | ||
description = "User #{user.name} created deployment group #{deployment_group.name}" | ||
AuditLogs.audit!(user, deployment_group, description) | ||
end | ||
|
||
@spec audit_deployment_updated(User.t(), DeploymentGroup.t()) :: :ok | ||
def audit_deployment_updated(user, deployment_group) do | ||
description = "User #{user.name} updated deployment group #{deployment_group.name}" | ||
AuditLogs.audit!(user, deployment_group, description) | ||
end | ||
|
||
@spec audit_deployment_deleted(User.t(), DeploymentGroup.t()) :: :ok | ||
def audit_deployment_deleted(user, deployment_group) do | ||
description = "User #{user.name} deleted deployment group #{deployment_group.name}" | ||
AuditLogs.audit!(user, deployment_group, description) | ||
end | ||
|
||
@spec audit_deployment_toggle_active(User.t(), DeploymentGroup.t(), String.t()) :: :ok | ||
def audit_deployment_toggle_active(user, deployment_group, status) do | ||
description = "User #{user.name} marked deployment group #{deployment_group.name} #{status}" | ||
AuditLogs.audit!(user, deployment_group, description) | ||
end | ||
|
||
@spec audit_deployment_mismatch(Device.t(), DeploymentGroup.t(), String.t()) :: :ok | ||
def audit_deployment_mismatch(device, deployment_group, reason) do | ||
description = | ||
"Device no longer matches deployment group #{deployment_group.name}'s requirements because of #{reason}" | ||
|
||
AuditLogs.audit!(device, deployment_group, description) | ||
end | ||
|
||
@spec audit_deployment_group_change(DeploymentGroup.t(), String.t()) :: :ok | ||
def audit_deployment_group_change(deployment_group, change_string) do | ||
description = "Deployment group #{deployment_group.name} #{change_string}" | ||
AuditLogs.audit!(deployment_group, deployment_group, description) | ||
end | ||
end |
47 changes: 0 additions & 47 deletions
47
lib/nerves_hub/audit_logs/templates/deployment_templates.ex
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These function names should change, but they shouldn't just have
_group
added to them. I want to make a more wholistic change to device template that removes the resource name from the function names, e.g.DeploymentGroupTemplates.audit_created
. We'll save that work for later.