Managed Deployments: Groups and Releases #1653
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nshoes
force-pushed
the
managed-deploys/remove-deployment-recalculation
branch
5 times, most recently
from
32abbc4 to
d34b3d2
Compare
nshoes
force-pushed
the
managed-deploys/deployment-groups-and-deployment-releases
branch
2 times, most recently
from
1b97ac0 to
5b70ac5
Compare
nshoes
force-pushed
the
managed-deploys/remove-deployment-recalculation
branch
2 times, most recently
from
4c72acc to
995a8f8
Compare
Base automatically changed from
managed-deploys/remove-deployment-recalculation
to
main
December 6, 2024 22:55
nshoes
force-pushed
the
managed-deploys/deployment-groups-and-deployment-releases
branch
from
5b70ac5 to
03e63ba
Compare
nshoes
changed the title
DeploymentGroups and DeploymentReleases
nshoes
force-pushed
the
managed-deploys/deployment-groups-and-deployment-releases
branch
from
03e63ba to
dc97780
Compare
nshoes
force-pushed
the
managed-deploys/deployment-groups-and-deployment-releases
branch
2 times, most recently
from
15dbf73 to
da17189
Compare
nshoes
added a commit
that referenced
this pull request
Feb 26, 2025
…platform when batch-updating (#1912) Previously, we displayed all deployments as options when batch-updating devices. This is confusing because you could see deployments that shouldn't be options. This PR now requires you to filter by platform first before having the ability to bulk move devices into a deployment. This change does create an extra step when moving devices to a deployment but it's important to note this is an interim feature before #1653 is finished.
nshoes
force-pushed
the
managed-deploys/deployment-groups-and-deployment-releases
branch
from
7a56134 to
4bbcfb9
Compare
nshoes
force-pushed
the
managed-deploys/deployment-groups-and-deployment-releases
branch
2 times, most recently
from
b2f510a to
97f872c
Compare
nshoes
commented
Mar 7, 2025
| alias NervesHub.ManagedDeployments.DeploymentGroup | ||
|
|
||
| @spec audit_deployment_created(User.t(), DeploymentGroup.t()) :: :ok | ||
| def audit_deployment_created(user, deployment_group) do |
There was a problem hiding this comment.
These function names should change, but they shouldn't just have _group added to them. I want to make a more wholistic change to device template that removes the resource name from the function names, e.g. DeploymentGroupTemplates.audit_created. We'll save that work for later.
nshoes
commented
Mar 7, 2025
| @@ -360,28 +360,6 @@ defmodule NervesHub.Devices do | |||
| end | |||
| end | |||
|
|
|||
| def get_eligible_deployments(%Device{firmware_metadata: nil}), do: [] | |||
There was a problem hiding this comment.
This function was unused.
nshoes
commented
Mar 7, 2025
| @@ -0,0 +1,15 @@ | |||
| defmodule NervesHub.ManagedDeployments.InflightDeploymentCheck do | |||
There was a problem hiding this comment.
No need to rename as we're planning on keeping the term "deployments" to describe the literal process instead of a resource.
nshoes
commented
Mar 7, 2025
| @@ -106,6 +106,10 @@ defmodule NervesHubWeb do | |||
|
|
|||
| def page_title(socket, page_title), do: assign(socket, :page_title, page_title) | |||
|
|
|||
| @spec sidebar_tab( | |||
nshoes
force-pushed
the
managed-deploys/deployment-groups-and-deployment-releases
branch
from
97f872c to
b9dd1e0
Compare
nshoes
force-pushed
the
managed-deploys/deployment-groups-and-deployment-releases
branch
from
b9dd1e0 to
76fc857
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work contains two sets of changes: the creation of
DeploymentReleases and the renaming ofdeploymentstodeployment_groups.DeploymentReleaseintegration will be done in the next body of work for managed deploys, this PR has become too big to add any more functionality.So many things have been renamed that it's easier to list what hasn't been renamed:
deploymentstable namedeploymentsin the namedeployment_idforeign key in DB and application codeDatabase-related renaming will be done later. Pub sub topic and events should and will be adjusted, but this is not the time. It won't be a simple rename and needs more care and thought.